Migrate from old progress bar API to the Android 16 ProgressStyle not…#14519
Open
alabiaga wants to merge 202 commits into
Open
Migrate from old progress bar API to the Android 16 ProgressStyle not…#14519alabiaga wants to merge 202 commits into
alabiaga wants to merge 202 commits into
Conversation
…ification template Change-Id: Iec413f429de462c3cb4b29f5ab99adc0edba0599
Contributor
Author
|
cc @alex-signal |
Co-authored-by: Greyson Parrelli <greyson@signal.org>
Move getParameterDescriptor and setParameters calls to after configure/start, since they require the codec to be in the Executing state. Always set KEY_COLOR_TRANSFER_REQUEST in the format before configure as the primary tone-mapping mechanism.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions! |
Contributor
|
Thanks for this, are the bump in build tools and dependencies required? Also could you rebase onto latest main instead of merging for a cleaner commit history on the PR, no biggie. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234syntax - N/ADescription
Migrate Signal's use of the progress bar API to the ProgressStyle notification template.
Note that I did not apply the Live Update treatment for notifications using the progress bar API that are ongoing.
That change will be separate once I align with the Signal team on whether those should be Live Updates.
Note that Signal's usage of the NotificationCompat lib will also gracefully fallback on the previous implementation as seen here in the NotificationCompat apply method.
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:core/core/src/main/java/androidx/core/app/NotificationCompat.java;l=5324?q=notificationcompat&ss=androidx%2Fplatform%2Fframeworks%2Fsupport