Fix scheduled Note To Self messages delivering without notifications …#14819
Open
terrancekhuang wants to merge 1 commit into
Open
Fix scheduled Note To Self messages delivering without notifications …#14819terrancekhuang wants to merge 1 commit into
terrancekhuang wants to merge 1 commit into
Conversation
…or preview update Fixes signalapp#13352
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…or preview update
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription
Fixes #13352
Fix 1: Conversation list preview not updated
IndividualSendJob and IndividualSendJobV2 called ThreadTable.updateSilently() after marking a scheduled message as sent. updateSilently skips notifyConversationListListeners(), so the UI never refreshes. Fixed by switching to ThreadTable.update().
Fix 2: No notification
Three layers of filtering combined to suppress the notification:
Fix: when ScheduledMessageManager fires a scheduled Note To Self message, it sets READ = 0 on that message via a new MessageTable.markAsUnread() helper. A new isNoteToSelfScheduled flag in NotificationStateProvider includes outgoing unread messages in Note To Self threads. shouldAlert() is updated to allow alerts for Note To Self conversations specifically (group conversations where you are the last sender remain unaffected). Finally, IndividualSendJob and IndividualSendJobV2 call MessageNotifier.updateNotification() after completing a Note To Self send to trigger the notification at the right moment.
Testing