Skip to content

chore: switch to @tony.ganchev/eslint-plugin-header#658

Open
tonyganchev wants to merge 1 commit into
signalapp:mainfrom
tonyganchev:main
Open

chore: switch to @tony.ganchev/eslint-plugin-header#658
tonyganchev wants to merge 1 commit into
signalapp:mainfrom
tonyganchev:main

Conversation

@tonyganchev

@tonyganchev tonyganchev commented Mar 15, 2026

Copy link
Copy Markdown

Hi team,

I noticed you are using eslint-plugin-header with the schema-turn-off
workaround to support ESLint 9.

I forked @tony.ganchev/eslint-plugin-header mid-2024 to address this
issue and hoped it would be a temporary measure but since the original
has not been updated for five years I decided to continue improving the
new plugin. Specific improvements include:

  • full JSON schema for validating the configuration.
  • fixed multiple bugs with the behavior of the plugin on Windows.
  • improved autofixing and error-reporting behavior.
  • added support for leading pragma comments before the header such as
    @jest-environment.

Looking forward to your feedback.

Signed-off-by: Tony Ganchev tony.ganchev@gmail.com

I noticed you are using _eslint-plugin-header_ with the schema-turn-off
workaround to support ESLint 9.

I forked _@tony.ganchev/eslint-plugin-header_ mid-2024 to address this
issue and hoped it would be a temporary measure but since the original
has not been updated for five years I decided to continue improving the
new plugin. Specific improvements include:

- full JSON schema for validating the configuration.
- fixed multiple bugs with the behavior of the plugin on Windows.
- improved autofixing and error-reporting behavior.
- added support for leading pragma comments before the header such as
  `@jest-environment`.

Looking forward to your feedback.

Signed-off-by: Tony Ganchev <tony.ganchev@gmail.com>
@github-actions

Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Jun 14, 2026

@tonyganchev tonyganchev left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks can I get a decision on this one? Either merge or close. Thanks!

@x64x2

x64x2 commented Jun 14, 2026

Copy link
Copy Markdown

If you really wanted to help, you'd submit a proper PR to eslint-plugin-header.

@tonyganchev

tonyganchev commented Jun 14, 2026

Copy link
Copy Markdown
Author

@x64x2 probably check my PR history with this eslint-plugin-header before giving me this passive aggressive response.

@github-actions github-actions Bot removed the stale label Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants