Improvements for members in Cargo.toml#667
Open
cvengler wants to merge 2 commits into
Open
Conversation
This orders the members field in the Cargo.toml using sort(1). I recommend to review this using `git diff --color-moved`.
This commit adds missing member entries to the members field in Cargo.toml. For this, I have compared the list against `find . -name Cargo.toml | sort` and entered these results. Some entries are not able to be included because their Cargo.toml is explicitly against this, in which cases I added a doc comment. Fixes signalapp#666
cvengler
force-pushed
the
cargo-toml-fixes
branch
from
8914625 to
c9c6b88
Compare
cvengler
added a commit
to cvengler/libsignal
that referenced
this pull request
Apr 19, 2026
When inspecting/auditing a Rust project, I find it helpful to get a nice overview of dependencies before doing so. Therefore, this commit introduces a dependency graph in the form of a mermaid diagram. The graph itself was generated using [cargo-structure](https://github.com/ramon54321/cargo-structure) alongside a trivial ad-hoc fix implementing Mermaid output for it. It uses the fix from signalapp#667 for this. Right now, the `mdbook` does not render this but the GitHub UI does.
cvengler
added a commit
to cvengler/libsignal
that referenced
this pull request
Apr 19, 2026
When inspecting/auditing a Rust project, I find it helpful to get a nice overview of dependencies before doing so. Therefore, this commit introduces a dependency graph in the form of a mermaid diagram. The graph itself was generated using [cargo-structure](https://github.com/ramon54321/cargo-structure) alongside a trivial ad-hoc fix implementing Mermaid output for it. It uses the fix from signalapp#667 for this. Right now, the `mdbook` does not render this but the GitHub UI does.
cvengler
added a commit
to cvengler/libsignal
that referenced
this pull request
Apr 19, 2026
When inspecting/auditing a Rust project, I find it helpful to get a nice overview of dependencies before doing so. Therefore, this commit introduces a dependency graph in the form of a mermaid diagram. The graph itself was generated using [cargo-structure](https://github.com/ramon54321/cargo-structure) alongside a trivial ad-hoc fix implementing Mermaid output for it. It uses the fix from signalapp#667 for this. Right now, the `mdbook` does not render this but the GitHub UI does.
cvengler
added a commit
to cvengler/libsignal
that referenced
this pull request
Apr 19, 2026
When inspecting/auditing a Rust project, I find it helpful to get a nice overview of dependencies before doing so. Therefore, this commit introduces a dependency graph in the form of a mermaid diagram. The graph itself was generated using [cargo-structure](https://github.com/ramon54321/cargo-structure) alongside a trivial ad-hoc fix implementing Mermaid output for it. It uses the fix from signalapp#667 for this. Right now, the `mdbook` does not render this but the GitHub UI does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the
membersfield inCargo.toml.For this, it does the following:
git diff --color-movedrust/core, toCargo.tomlFixes #666