X3DH w/ PVRF SAS-MA extension POC#673
Draft
21pchangkachith wants to merge 61 commits into
Draft
Conversation
Went line by line and commented basic explanations for the variables and functions. Tried to correspond variables with the paper's syntax as much as possible, but may need to add more detail later. May add more info about external files and their connections once I figure those ones out. Used AI and the internet for help with explanations, but the comments are all mine.
Commented functions/variables in protocol.rs and noted function calls to protocol.rs in session.rs
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
mainbranchcargo testrun passes successfully (Description
Describe briefly what your pull request changes. Focus on the value provided to users.
Product of a capstone project from MCS at UCI.
Implements an extension to the X3DH communication protocol outlined in: https://eprint.iacr.org/2026/522.
This PR is for the protocol-end to calculate PVRF-data and warn the user if malformed data is detected. The user value stems from the possibility of a compromised or otherwise incorrect KDS, users will be able to verify each other on a stronger & more familiar level than public-key verification via safety numbers. The research paper details our approach in more detail.
Does it address any outstanding issues in this project?
https://github.com/signalapp/Signal-Desktop/issues?utf8=%E2%9C%93&q=is%3Aissue
Reference an issue with the hash symbol: "#222"
If you're fixing it, use something like "Fixes #222"
No
Please write a summary of your test approach:
Manual resets of application data to continuously recompute X3DH, testing with multiple OSX devices
Yes, 3 unit tests and 1 extra benchmark.
m1 OSX Venture 13.5
m1 OSX
This PR will be dependent on the corresponding Signal-Desktop PR (signalapp/Signal-Desktop#7908)
We were unable to rebase & test this code by our deadline, but we will return to do this before we take this PR out of draft.
Meanwhile, here's an internal PR to an older version of libsignal to preview just the diff: 21pchangkachith#9
Team members:
Phoenix Changkachith
Minh Dang
Natasha Jha
Mary Hemker
Research credit:
Stanislaw Jarecki
Phillip Nazarian
Apurva Rai