[chore] check resattributes and component error in gce#2331
Merged
Conversation
jinja2
commented
Mar 30, 2026
| @@ -0,0 +1,51 @@ | |||
| resourceMetrics: | |||
Collaborator
Author
There was a problem hiding this comment.
There are no cloud.* attributes due to gcp detector not being added when cloudProvider=gcp and distribution="". This gets fixed in PR #2330
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables and aligns the GCE (kops) functional test environment with other hosted-cluster environments by adding a dedicated values template plus “golden” expected resource-attribute outputs, and wiring GCE into the existing hosted-cluster validation + component-health checks.
Changes:
- Add a GCE-specific Helm values template used by functional tests.
- Add expected (“golden”) resource-attributes YAMLs for agent and cluster-receiver in GCE.
- Enable GCE in hosted-cluster functional test routing and in the GitHub Actions workflow (no longer skipping tests).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| functional_tests/functional/testdata/values/gce_test_values.yaml.tmpl | New GCE functional-test Helm values template (agent/clusterReceiver config + extraAttributes). |
| functional_tests/functional/testdata/expected_gce_values/expected_resource_attributes_agent.yaml | New golden file for agent resource-attributes validation in GCE. |
| functional_tests/functional/testdata/expected_gce_values/expected_resource_attributes_cluster_receiver.yaml | New golden file for cluster-receiver resource-attributes validation in GCE. |
| functional_tests/functional/functional_test.go | Add GCE expected-values directory selection and include GCE in hosted-cluster validations/health checks. |
| .github/workflows/functional_test_v2.yaml | Enable the GCE job by removing SKIP_TESTS: "true". |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dloucasfx
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add resource attributes validation and component health checks for the GCE (kops) functional test environment, matching the pattern used by EKS, AKS, GKE, and ROSA tests.