Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR pins Helm to v4.1.4 in the update_docker_images and release_drafter GitHub Actions workflows to prevent them from falling back to the runner’s preinstalled Helm 3, which was causing rendered-manifest “flap” PR loops.
Changes:
- Add an explicit
azure/setup-helmstep toupdate_docker_images.yamlwithversion: v4.1.4. - Add an explicit
azure/setup-helmstep torelease_drafter.yamlwithversion: v4.1.4.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/update_docker_images.yaml | Pins Helm to v4.1.4 so make render / helm template uses the intended Helm version. |
| .github/workflows/release_drafter.yaml | Pins Helm to v4.1.4 so release draft PRs render manifests consistently. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Pin Helm to
v4.1.4inupdate_docker_images.yamlandrelease_drafter.yaml. Both workflows commit rendered manifests viamake render(->helm template) but they were silently falling back to the runner's pre-installed Helm 3.The result is a render-flap loop:
update_docker_images/release_drafteropen a PR with manifests rendered by Helm 3 (example). Next time anything Helm-4-pinned runsmake render, it reverts/rewrites those manifests.