Add smoke test for snapshot profiler#2249
Merged
laurit merged 2 commits intosignalfx:mainfrom Apr 2, 2025
Merged
Conversation
tduncan
reviewed
Mar 25, 2025
| logger.info("Petclinic has been started."); | ||
|
|
||
| try { | ||
| generateSomeSpans(); |
Contributor
There was a problem hiding this comment.
Given the random nature of selecting traces for snapshotting it may be necessary to continuously send requests. With this setup we should expect 2 traces to be selected, but there will definitely be iterations where 0 of the 200 traces are selected.
Collaborator
Author
There was a problem hiding this comment.
I increased the selection rate and iteration count.
tduncan
approved these changes
Mar 26, 2025
robsunday
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from the existing profiler smoke test. cc @tduncan