Skip to content

Improve log statement #2494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robsunday merged 1 commit into from
Oct 24, 2025
Merged

Improve log statement #2494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .../src/main/java/com/splunk/opentelemetry/resource/TruncateCommandLineResourceDetector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,11 @@
@SuppressWarnings("rawtypes")
@AutoService(ComponentProvider.class)
public class TruncateCommandLineResourceDetector implements ComponentProvider<Resource> {
private static final int MAX_COMMAND_LINE_LENGTH = 255;
private static final Logger logger =
Logger.getLogger(TruncateCommandLineResourceDetector.class.getName());

private static final int MAX_COMMAND_LINE_LENGTH = 255;

@Override
public Class<Resource> getType() {
return Resource.class;
Expand All @@ -53,7 +54,7 @@ public Resource create(DeclarativeConfigProperties config) {

List<String> commandArgs = resource.getAttribute(PROCESS_COMMAND_ARGS);
if (commandArgs != null) {
logger.fine(() -> "Truncate resource attribute" + PROCESS_COMMAND_ARGS.getKey());
logger.fine(() -> "Truncate resource attribute " + PROCESS_COMMAND_ARGS.getKey());
List<String> newCommandArgs = truncate(commandArgs, MAX_COMMAND_LINE_LENGTH);
if (newCommandArgs != null) {
resource =
Expand All @@ -63,7 +64,7 @@ public Resource create(DeclarativeConfigProperties config) {

String commandLine = resource.getAttribute(PROCESS_COMMAND_LINE);
if (commandLine != null && commandLine.length() > MAX_COMMAND_LINE_LENGTH) {
logger.fine(() -> "Truncate resource attribute" + PROCESS_COMMAND_LINE.getKey());
logger.fine(() -> "Truncate resource attribute " + PROCESS_COMMAND_LINE.getKey());
String newCommandLine = commandLine.substring(0, MAX_COMMAND_LINE_LENGTH - 3) + "...";
resource =
resource.merge(Resource.create(Attributes.of(PROCESS_COMMAND_LINE, newCommandLine)));
Expand Down