Merged
Conversation
robsunday
reviewed
Nov 3, 2025
| if (serviceName != null) { | ||
| return serviceName; | ||
| } | ||
| return resource.getAttribute(ServiceAttributes.SERVICE_NAME); |
Contributor
There was a problem hiding this comment.
That's great that it will work with declarative config, however I have one doubt here. With current implementation if YAML contains:
resource:
attributes:
- name: service.name
value: "Service 1"
instrumentation/development:
java:
otel:
service:
name: "Service 2"then "Service 2" will be used, overriding content of node .resource.attributes (Service 1). Also results of detectors will be overridden I guess. If this is what we want then that's fine. If not, then resource.getAttribute(ServiceAttributes.SERVICE_NAME) should be checked first, before otel.service.name and otel.resource.attributes
Collaborator
Author
There was a problem hiding this comment.
I copied from service name checker without thinking about it. I guess here we really don't need to do anything besides calling resource.getAttribute(ServiceAttributes.SERVICE_NAME)
custom/src/test/java/com/splunk/opentelemetry/opamp/OpampActivatorTest.java
Outdated
Show resolved
Hide resolved
custom/src/test/java/com/splunk/opentelemetry/opamp/OpampActivatorTest.java
Show resolved
Hide resolved
custom/src/test/java/com/splunk/opentelemetry/opamp/OpampActivatorTest.java
Outdated
Show resolved
Hide resolved
robsunday
approved these changes
Nov 3, 2025
breedx-splk
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds an opamp client that just connects to the server and doesn't do anything else.