Update configs to match gdi-spec changes#2516
Conversation
| @@ -34,7 +34,7 @@ public class SnapshotProfilingConfiguration implements AutoConfigurationCustomiz | |||
| "splunk.snapshot.profiler.enabled"; | |||
| private static final String SELECTION_PROBABILITY_KEY = "splunk.snapshot.selection.probability"; | |||
| private static final String STACK_DEPTH_KEY = "splunk.snapshot.profiler.max.stack.depth"; | |||
There was a problem hiding this comment.
would it also make sense to change the stack depth property and other properties that start with splunk.snapshot.profiler?
There was a problem hiding this comment.
Or actually prefix everything with splunk.profiler.snapshot. , since snapshots are part of profiler. This would also create more logical composition of properties in declarative config yaml. Something like:
instrumentation/development:
java:
splunk:
profiler:
enabled: true #splunk.profiler.enabled (default: false)
directory: #splunk.profiler.directory (default: system specific temp dir)
snapshot:
enabled: true
export:
interval: 10000
sampling:
interval: 5000
selection:
probability: 0.025
staging:
capacity: 100
max:
stack:
depth: 1000There was a problem hiding this comment.
would it also make sense to change the stack depth property and other properties that start with
splunk.snapshot.profiler?
Maybe, but that's out of scope right now. I only wanted to align the 3 main ones for now.
There was a problem hiding this comment.
Or actually prefix everything with splunk.profiler.snapshot. , since snapshots are part of profiler.
This is a step backwards. If you feel strongly about this, then please open an issue in gdi-specification. I think shorter is better than longer, and shallower is better than deeper...but let's not argue about that in this PR please.
Aligns with #353 in gdi-spec.
This should be considered a breaking change for any users currently using snapshots.