Skip to content

Update configs to match gdi-spec changes#2516

Merged
breedx-splk merged 1 commit intosignalfx:mainfrom
breedx-splk:update_snapshot_configs
Nov 4, 2025
Merged

Update configs to match gdi-spec changes#2516
breedx-splk merged 1 commit intosignalfx:mainfrom
breedx-splk:update_snapshot_configs

Conversation

@breedx-splk
Copy link
Copy Markdown
Contributor

Aligns with #353 in gdi-spec.
This should be considered a breaking change for any users currently using snapshots.

@breedx-splk breedx-splk requested review from a team as code owners November 3, 2025 18:41
@@ -34,7 +34,7 @@ public class SnapshotProfilingConfiguration implements AutoConfigurationCustomiz
"splunk.snapshot.profiler.enabled";
private static final String SELECTION_PROBABILITY_KEY = "splunk.snapshot.selection.probability";
private static final String STACK_DEPTH_KEY = "splunk.snapshot.profiler.max.stack.depth";
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it also make sense to change the stack depth property and other properties that start with splunk.snapshot.profiler?

Copy link
Copy Markdown
Contributor

@robsunday robsunday Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or actually prefix everything with splunk.profiler.snapshot. , since snapshots are part of profiler. This would also create more logical composition of properties in declarative config yaml. Something like:

instrumentation/development:
  java:  
    splunk:
      profiler:
        enabled: true #splunk.profiler.enabled (default: false)
        directory: #splunk.profiler.directory (default: system specific temp dir)

        snapshot:
          enabled: true
          export:
            interval: 10000
          sampling:
            interval: 5000
          selection:
            probability: 0.025
          staging:
            capacity: 100
          max:
            stack:
              depth: 1000

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it also make sense to change the stack depth property and other properties that start with splunk.snapshot.profiler?

Maybe, but that's out of scope right now. I only wanted to align the 3 main ones for now.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or actually prefix everything with splunk.profiler.snapshot. , since snapshots are part of profiler.

This is a step backwards. If you feel strongly about this, then please open an issue in gdi-specification. I think shorter is better than longer, and shallower is better than deeper...but let's not argue about that in this PR please.

@breedx-splk breedx-splk merged commit 4683a8e into signalfx:main Nov 4, 2025
28 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants