[File based config] Appd agent version resource supported #2605
Merged
robsunday merged 2 commits intosignalfx:mainfrom Jan 27, 2026
Merged
[File based config] Appd agent version resource supported #2605robsunday merged 2 commits intosignalfx:mainfrom
robsunday merged 2 commits intosignalfx:mainfrom
Conversation
laurit
approved these changes
Jan 27, 2026
laurit
reviewed
Jan 27, 2026
| try { | ||
| // given | ||
| String appDVersion = "version X"; | ||
| System.setProperty( |
Collaborator
There was a problem hiding this comment.
could consider using junit @SetSystemProperty annotation
Contributor
Author
There was a problem hiding this comment.
I'd use it, but it is available in the additional extension. I think adding next dependency is not worth it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of AppDynamicsVersionResourceProvider