[File based config] Support for nocode rules embedded in declarative config YAML#2623
Merged
robsunday merged 5 commits intosignalfx:mainfrom Feb 12, 2026
Merged
Conversation
robsunday
commented
Feb 3, 2026
| public void beforeAgent(AutoConfiguredOpenTelemetrySdk autoConfiguredOpenTelemetrySdk) { | ||
| ConfigProperties config = getConfig(autoConfiguredOpenTelemetrySdk); | ||
| if (isDeclarativeConfig(autoConfiguredOpenTelemetrySdk)) { | ||
| processEmbeddedRules(getConfigProvider(autoConfiguredOpenTelemetrySdk)); |
Contributor
Author
There was a problem hiding this comment.
[for reviewer] To be discussed: Is it the right approach to merge rules from embedded rules and rules from external file? Maybe these options should be mutually exclusive?
Contributor
Author
There was a problem hiding this comment.
[for reviewer] The PO preference is to have these options mutually exclusive
Contributor
There was a problem hiding this comment.
I think that you are free to choose. Merging certainly seems like it makes things more complicated, but it's fine if you wanna go that route.
Contributor
Author
There was a problem hiding this comment.
Merging approach may lead to some confusion, so I also prefer mutually exclusive version.
breedx-splk
reviewed
Feb 11, 2026
.../nocode/src/main/java/com/splunk/opentelemetry/instrumentation/nocode/NocodeInitializer.java
Outdated
Show resolved
Hide resolved
breedx-splk
approved these changes
Feb 11, 2026
…instrumentation/nocode/NocodeInitializer.java Co-authored-by: jason plumb <75337021+breedx-splk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No Code Instrumentation rules can now be delivered inside the declarative config YAML file.
Example:
It is still possible to configure No Code Instrumentation using separate file.
For declarative config it's path should be provided with this snippet:
If both forms are present in YAML, then the results are merged.