Context propagation for mysql and mariadb#2681
Merged
laurit merged 4 commits intosignalfx:mainfrom Mar 5, 2026
Merged
Conversation
robsunday
reviewed
Mar 3, 2026
|
|
||
| @Override | ||
| public boolean isHelperClass(String className) { | ||
| return className.startsWith("com.splunk.opentelemetry.instrumentation"); |
Contributor
There was a problem hiding this comment.
This implementation is already repeated few times in our repo. Maybe className.startsWith("com.splunk.opentelemetry.instrumentation") could go to some helper class or an interface as a static method and be called from here?
Collaborator
Author
There was a problem hiding this comment.
we could introduce SplunkInstrumentationModule and put that method there and use that class in our instrumentations instead of InstrumentationModule
...on/jdbc/src/test/java/com/splunk/opentelemetry/instrumentation/jdbc/mariadb/MariaDbTest.java
Outdated
Show resolved
Hide resolved
robsunday
reviewed
Mar 4, 2026
...a/com/splunk/opentelemetry/instrumentation/jdbc/mariadb/MariaDbStatementInstrumentation.java
Outdated
Show resolved
Hide resolved
robsunday
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.