Proxy replaced with delegating config properties#2696
Merged
laurit merged 1 commit intosignalfx:mainfrom Mar 12, 2026
Merged
Conversation
breedx-splk
reviewed
Mar 11, 2026
| } | ||
|
|
||
| @Override | ||
| public ConfigProvider getConfigProvider() { |
Contributor
There was a problem hiding this comment.
Too bad java doesn't have first-class delegation support like kotlin. 😭
breedx-splk
approved these changes
Mar 11, 2026
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
Seems ok to me, hack hack hack away!
laurit
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is alternative for Proxy use introduced by #2695
The class implementing
ExtendedDeclarativeConfigPropertiesinterface is used instead of the Proxy.Benefit from proposed solution is that any breaking changes made to ExtendedDeclarativeConfigProperties interface will raise some compilation error. Proxy based solution may get silently broken when
ExtendedDeclarativeConfigProperties.getConfigProvideris renamed or removed.