Skip to content

Issue #2689: Unsatisfactory behavior of snapshot selector [recreated]#2717

Open
robsunday wants to merge 1 commit intosignalfx:mainfrom
robsunday:Unsatisfactory_behavior_of_snapshot_selector
Open

Issue #2689: Unsatisfactory behavior of snapshot selector [recreated]#2717
robsunday wants to merge 1 commit intosignalfx:mainfrom
robsunday:Unsatisfactory_behavior_of_snapshot_selector

Conversation

@robsunday
Copy link
Copy Markdown
Contributor

This PR contains all the changes from PR #2697
New PR was the easiest way to fix the issue with missing signature on one of the commits from original PR.

Repeated description of changes:

Change the algorithm for snapshot profiling selection to be exclusively based on trace-id. Removing the concepts of snapshot Volume, SnapshotVolumePropagator, and ProbabilisticSnapshotSelector. Updating unit tests.

Credits for the implementation go to @PeterF778

@robsunday robsunday requested review from a team as code owners March 19, 2026 09:41
Copy link
Copy Markdown

@PeterF778 PeterF778 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help, Robert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants