Add current_span option to nocode instrumentation#2726
Open
johnbley wants to merge 2 commits intosignalfx:mainfrom
Open
Add current_span option to nocode instrumentation#2726johnbley wants to merge 2 commits intosignalfx:mainfrom
johnbley wants to merge 2 commits intosignalfx:mainfrom
Conversation
Contributor
Author
|
codex spec with many human typos, for reference: A first draft of this went off the rails as codex couldn't figure out how to rerun the necessary build steps when editing bootstrap code, so I helped it along by doing that manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
current_span: trueoption to nocode rules, allowing you to add attributes to the currently active span by adding runtime instrumentation to a method as before. This makes it easier to support usage like capturing a cookie value on a root servlet span, without needing to create a child span just to have the cookie value.span_nameandspan_statushave no effect (besides logging a parse-time warning about this) on current-span rulesThis PR was created by codex 5.4 extra-high from my spec (listed in comment for completeness), with some light tweaking/tuning/commenting by me.