Merged
Conversation
seemk
reviewed
Mar 18, 2026
|
|
||
| if (configSampler === undefined) { | ||
| if (getNonEmptyEnvVar('OTEL_TRACES_SAMPLER') === undefined) { | ||
| const envSampler = getNonEmptyEnvVar('OTEL_TRACES_SAMPLER'); |
Contributor
There was a problem hiding this comment.
Should the rule based sampler be configurable via the config file?
- can it be passed in via programmatic API?
Contributor
Author
There was a problem hiding this comment.
config file: Probably better to then fully support composite/development sampler
splunk-otel-js/src/configuration.ts
Line 600 in 8a581bd
unclear if in scope for now
programmattic API: User can compose it by using @opentelemetry/sampler-composite package directly
seemk
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically a port of java's implementation (including basically copy-paste of java's documentation). When running tests http instrumentation seems to still use the old semconv (sfx app makes it so both attributes show up), so the checks use both old and new attribute names.
Composite Sampler is quite a new package so 🙏