fix: create spinner-aware logger to more easily avoid jumbled logs#140
Merged
fix: create spinner-aware logger to more easily avoid jumbled logs#140
Conversation
92fa42f to
fdb822c
Compare
spinner.interrupt functionality already existed, but it required code to manually use it. createLogger now accepts a spinner, so any calls to such a logger will automatically go through spinner.interrupt for safe logging when a spinner is present
fdb822c to
dcc8d05
Compare
tonzhan2
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spinner.interrupt functionality already existed, but it required code to manually use it.
createLogger now accepts a spinner, so any calls to such a logger will automatically go through spinner.interrupt for safe logging when a spinner is present
Before (the active spinner text "Uploading ..." stays in the console and jumbles some of the debug logs):
After (the active spinner text "Uploading..." is no longer present after command is finished, and logs take up their own line as expected):