Remove upper limit of dependencies version#25
Open
laggykiller wants to merge 1 commit intosignalstickers:masterfrom
Open
Remove upper limit of dependencies version#25laggykiller wants to merge 1 commit intosignalstickers:masterfrom
laggykiller wants to merge 1 commit intosignalstickers:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a library, it is bad practice to to set upper limit of dependencies' version.
Everytime a new python version is released and library releases new version, things break and we have to wait for signalstickers-client to remove the version restriction (#21)
You may argue that the dependency may release a new major version that break signalstickers-client, but this could still be temporarily mitigated by the user by specifying the dependency version themselves in
requirements.txt.However, if signalstickers-client add upper bound to library version and a dependency release a new version that is actually compatible, the only way for the user to install signalstickers-client with newer version of dependency is git clone this repo, change dependency version requirement in
setup.pythemselves and pip install. Also note that if the user of this library do this, they cannot publish their library to PyPI as the dependency of a library on PyPI cannot be a git repo (Gets rejected during wheel upload).This article discuss about this problem: https://iscinumpy.dev/post/bound-version-constraints/
This PR removes upper limit on dependencies' version.