-
Notifications
You must be signed in to change notification settings - Fork 8
Remove (Old) CXML Applications - 13601 #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Devon-White
merged 6 commits into
main
from
cassie/13601/cxml_applications/remove_existing_endpoints
Apr 18, 2025
Merged
Remove (Old) CXML Applications - 13601 #188
Devon-White
merged 6 commits into
main
from
cassie/13601/cxml_applications/remove_existing_endpoints
Apr 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for signalwire-docs failed.
|
OpenAPI Specification AnalysisChanges are compared to the
|
✅ Deploy Preview for signalwire-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
imfaruk
previously approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Devon-White
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REST API Update Pull Request
Related Issue
If there's an issue available, link it here: Issue #13601
Description
This PR removes the existing CXML Application fabric API endpoints. It is part of the epic to ensure the UI, API, and documentation are all aligned with the latest version of Call Fabric.
Type of Change
Motivation and Context
We are auditing our API endpoints for Call Fabric against the UI and documentation. There are many inconsistencies that have happened through rapid development, and this will undoubtedly be confusing for customers. We should make sure that all reflect the same functionality.
In the first iteration of call fabric, we had an resource type called 'CXML Applications'. (note: this is not the CXML applications you see in the UI - see LaML Applications in main ticket for more detail on this).They were meant to allow a user to select whether they want to use a hosted script or an external URL, and contained the necessary configuration details depending on the answer.
The ability to create or use these has gone away entirely from the UI, but we still have the API endpoints and documentation.
LaML Applications will be renamed CXML Applications for consistency with CXML Webhooks and CXML Scripts, so we to get rid of these first.
Checklist:
team/developer-experience
label in the PR.Additional Notes
The build is failing on compilation because of a guide that references these deleted endpoints: /compatibility-api/guides/general/creating-and-using-cxml-applications
I'm not sure whether we want to delete the document, or modify it, or something along those lines? I left it alone for now