[mod_amqp] prevent segfault on double connection close#3054
Open
greenbea wants to merge 1 commit into
Open
Conversation
When a command response publish failed, `mod_amqp_command_response` closed the connection and cleared conn_active. The command thread teardown then called mod_amqp_connection_close(NULL), causing a segfault. Also fix amqp_error_string2() calls to pass status codes without erroneous negation.
Contributor
Author
|
segfault |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a command response publish failed,
mod_amqp_command_responseclosed the connection and cleared conn_active. The command thread teardown then calledmod_amqp_connection_close(NULL), causing a segfault.Here's the test I've used to reproduce this.
test.zip
Also fix
amqp_error_string2()calls to pass status codes without erroneous negation.Description
Type of Change
Related Issues
Testing
Checklist
Additional Notes