Allow data function to return a promise#611
Open
srmagura wants to merge 2 commits intosignavio:masterfrom
Open
Allow data function to return a promise#611srmagura wants to merge 2 commits intosignavio:masterfrom
data function to return a promise#611srmagura wants to merge 2 commits intosignavio:masterfrom
Conversation
🦋 Changeset detectedLatest commit: ea8a670 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Any chance to get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #314.
If the
datafunction returns aPromiseor other thenable, the suggestions are updated when the promise resolves.The type definitions already have
Promiseas a valid return type forDataFunc, so this PR brings the actual functionality in line with what you would expect from the types.I added tests for both types of async data functions, callback-based and promise-based.
I have the Prettier extension enabled and it made some formatting changes. If necessary, I can disable the extension and remake my changes so the diff is as small as possible.