fix: match korean substring for suggestions#618
Open
woosuk288 wants to merge 1 commit intosignavio:masterfrom
Open
fix: match korean substring for suggestions#618woosuk288 wants to merge 1 commit intosignavio:masterfrom
woosuk288 wants to merge 1 commit intosignavio:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 76b5bdc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
oinochoe
approved these changes
Dec 12, 2022
|
@signavio I've encountered the same issue, and I'm really hoping for a fix on this functionality. Could you please proceed with the merge at your earliest convenience? It would greatly improve the usability of the library. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #257 but only Korean.
#257 has been same problem in Korean as well but no one has seemed to fix this yet for quite a long. so I tried this.
- Before
- After
I think ch2pattern function could help pattern match from other languages if people know their language's regex pattern.