Update Lighthouse #304
Update Lighthouse #304
Conversation
- CK's dvt changes - Remove `sign_validator_exit` from trait
|
Could you please describe what "CK's dvt changes" means? |
|
@diegomrsantos sorry, added a link |
Thank you. Could you please add a short motivation for the new code added? Unfortunately, I couldn't see a short description. |
anchor/client/src/lib.rs
Outdated
| @@ -486,7 +491,18 @@ impl Client { | |||
| .spec(spec.clone()) | |||
| .executor(executor.clone()) | |||
| //.enable_high_validator_count_metrics(config.enable_high_validator_count_metrics) | |||
| .distributed(true) | |||
| .attestation_selection_proof_config(SelectionProofConfig { | |||
There was a problem hiding this comment.
[nit] Is this for aggregation? If so, maybe attestation_aggregation_selection_proof_config?
There was a problem hiding this comment.
I think this is too verbose. The word aggregation adds no additional information IMO.
There was a problem hiding this comment.
There's no proof for pure attestation, right?
There was a problem hiding this comment.
selection proofs are always for aggregations - so the word aggregation is redundant
There was a problem hiding this comment.
I try to think from the perspective of someone who doesn't know the domain very well.
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Lighthouse codebase by removing the deprecated sign_voluntary_exit functionality from the validator store, updating dependency revisions, and tweaking client timeout configurations and builder setups.
- Removed the sign_voluntary_exit function from the validator store to match the updated trait.
- Updated dependency revisions in Cargo.toml to use new commit hashes.
- Modified client timeout calculations and replaced the distributed flag with explicit selection proof configuration settings.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| anchor/validator_store/src/lib.rs | Removed the sign_voluntary_exit function to align with the updated trait requirements. |
| anchor/client/src/lib.rs | Updated timeout constants and added selection proof configuration while revising imports. |
| Cargo.toml | Updated dependency revisions to the new commit hash version (86a106b94) and gossipsub rev. |
Comments suppressed due to low confidence (1)
anchor/client/src/lib.rs:495
- The removal of the distributed(true) call is a significant change in behavior; please verify that the new selection proof configurations fully replace the previous distributed mode functionality.
.distributed(true)
@diegomrsantos The Lighthouse code presently exhibits some behaviour regarding selection proofs that are both incompatible with SSV and Obol's DVT middleware, so these changes make it configurable to accommodate the needs of all three scenarios (SSV, Obol, and classic VC). See also sigp/lighthouse#7016 (comment) or ping me :) |
selectionsBeacon API endpoints to support DVT middleware lighthouse#7016validator_serviceslighthouse#7427