ProgressiveBitList and compatible union support #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added CompatibleUnion to EnumBehaviour enum - Updated Procedure::read() to recognize "compatible_union" syntax - Implemented ssz_encode_derive_enum_compatible_union() for encoding - Implemented ssz_decode_derive_enum_compatible_union() for decoding - Added compute_compatible_union_selectors() helper (selectors 128-255) - Updated documentation with compatible_union examples - Added comprehensive tests for compatible unions - All tests passing Co-authored-by: michaelsproul <[email protected]>
- Changed u8::max_value to u8::MAX to match Rust conventions - Improved assertion message clarity Co-authored-by: michaelsproul <[email protected]>
- Changed selector range from 128-255 to 1-127 - Updated compute_compatible_union_selectors to start at 1 - Fixed debug assertions to validate selector > 0 and <= 127 - Updated all tests to use selectors 1 and 2 instead of 128 and 129 - Updated documentation to reflect correct selector range Co-authored-by: michaelsproul <[email protected]>
- Simplified decode error handling to directly check for empty bytes - Fixed error message to reference MAX_UNION_SELECTOR (127) instead of u8::MAX - Clarified that compatible unions are limited to 127 variants (1-127) Co-authored-by: michaelsproul <[email protected]>
…ible-unions' into progressive
michaelsproul
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 76.52% 76.47% -0.06%
==========================================
Files 14 15 +1
Lines 805 867 +62
==========================================
+ Hits 616 663 +47
- Misses 189 204 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
This was referenced Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup of:
With other changes added as I hack the EF tests to get them passing.