@@ -3235,6 +3235,7 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
32353235 // Reject RPC columns referencing unknown parents. Otherwise we allow potentially invalid data
32363236 // into the da_checker, where invalid = descendant of invalid blocks.
32373237 // Note: custody_columns should have at least one item and all items have the same parent root.
3238+ // TODO(gloas) ensure this check is no longer relevant post gloas
32383239 if let Some ( parent_root) = custody_columns
32393240 . iter ( )
32403241 . filter_map ( |c| match c. as_ref ( ) {
@@ -3562,6 +3563,7 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
35623563 ) -> Result < AvailabilityProcessingStatus , BlockError > {
35633564 if let Some ( slasher) = self . slasher . as_ref ( ) {
35643565 for data_column in & data_columns {
3566+ // TODO(gloas) no block header post-gloas, what should we do here
35653567 if let DataColumnSidecar :: Fulu ( c) = data_column. as_data_column ( ) {
35663568 slasher. accept_block_header ( c. signed_block_header . clone ( ) ) ;
35673569 }
@@ -3642,6 +3644,7 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
36423644 . put_kzg_verified_blobs ( block_root, blobs) ?
36433645 }
36443646 EngineGetBlobsOutput :: CustodyColumns ( data_columns) => {
3647+ // TODO(gloas) verify that this check is no longer relevant for gloas
36453648 self . check_data_column_sidecar_header_signature_and_slashability (
36463649 block_root,
36473650 data_columns
@@ -3668,6 +3671,7 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
36683671 block_root : Hash256 ,
36693672 custody_columns : DataColumnSidecarList < T :: EthSpec > ,
36703673 ) -> Result < AvailabilityProcessingStatus , BlockError > {
3674+ // TODO(gloas) ensure that this check is no longer relevant post gloas
36713675 self . check_data_column_sidecar_header_signature_and_slashability (
36723676 block_root,
36733677 custody_columns. iter ( ) . filter_map ( |c| match c. as_ref ( ) {
0 commit comments