Skip to content

Global ENR #4855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: unstable
Choose a base branch
from
Open

Global ENR #4855

wants to merge 11 commits into from

Conversation

jmcph4
Copy link
Member

@jmcph4 jmcph4 commented Oct 18, 2023

Issue Addressed

Closes #4706

Proposed Changes

  • Add an EnrPort type, representing ports we advertise in our ENR
  • Add a MutableEnr type, representing a single handle to a writeable ENR
  • Remove ad-hoc ENR port update helpers (update_enr_tcp_port, update_enr_udp_port, etc.)

Additional Info

TBA

@jmcph4 jmcph4 self-assigned this Oct 18, 2023
@jmcph4 jmcph4 added work-in-progress PR is a work-in-progress enhancement New feature or request labels Oct 18, 2023
Copy link

mergify bot commented Mar 4, 2025

This pull request has merge conflicts. Could you please resolve them @jmcph4? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Networking work-in-progress PR is a work-in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants