Skip to content

Migrate account manager cli client to clap derive #6493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: unstable
Choose a base branch
from
Open

Migrate account manager cli client to clap derive #6493

wants to merge 20 commits into from

Conversation

eserilev
Copy link
Collaborator

Issue Addressed

Partially #5900

Proposed Changes

Migrate account-manager to clap derive

@eserilev eserilev mentioned this pull request Oct 16, 2024
Open
8 tasks
@eserilev eserilev added the ready-for-review The code is ready for review label Oct 16, 2024
macladson
macladson requested changes Oct 26, 2024
View reviewed changes
Copy link
Member

@macladson macladson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR needs some of the same love from #6300 since lighthouse am --help also doesn't work.

@macladson macladson added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Oct 26, 2024
@jxs jxs mentioned this pull request Dec 18, 2024
Merged
@eserilev eserilev added the v7.0.0-beta.0 New release c. Q1 2025 label Jan 16, 2025
@eserilev eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 16, 2025
@michaelsproul michaelsproul added v7.1.0 Post-Electra release and removed v7.0.0-beta.0 New release c. Q1 2025 labels Feb 6, 2025
@mergify Mergify
Copy link

mergify bot commented Feb 6, 2025

This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏

@eserilev
Copy link
Collaborator Author

this one should be g2g for another review

macladson
macladson requested changes Apr 24, 2025
View reviewed changes
Copy link
Member

@macladson macladson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will leave a more thorough review soon, but noticed some comments that need updating

@mergify Mergify
Copy link

mergify bot commented Apr 24, 2025

This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏

macladson
macladson requested changes Apr 25, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macladson macladson macladson requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
code-quality ready-for-review The code is ready for review v7.1.0 Post-Electra release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eserilev @macladson @michaelsproul