Remove pending requests from ready_requests #6625
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
We don't need to store `BehaviourAction` for `ready_requests` and therefore avoid having an `unreachable!` on #6625. Therefore this PR should be merged before it
pawanjay176
pushed a commit
to pawanjay176/lighthouse
that referenced
this pull request
Feb 21, 2025
We don't need to store `BehaviourAction` for `ready_requests` and therefore avoid having an `unreachable!` on sigp#6625. Therefore this PR should be merged before it
eserilev
pushed a commit
to eserilev/lighthouse
that referenced
this pull request
Mar 5, 2025
We don't need to store `BehaviourAction` for `ready_requests` and therefore avoid having an `unreachable!` on sigp#6625. Therefore this PR should be merged before it
|
This pull request has merge conflicts. Could you please resolve them @ackintosh? 🙏 |
mergify
bot
added
waiting-on-author
|
Hi @ackintosh, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time. |
mergify
bot
added
the
stale
# Conflicts: # beacon_node/lighthouse_network/src/rpc/self_limiter.rs
mergify
bot
added
ready-for-review
ackintosh
removed
the
stale
# Conflicts: # beacon_node/lighthouse_network/src/rpc/self_limiter.rs
dapplion
reviewed
Oct 26, 2025
| true | ||
| } | ||
| } else { | ||
| unreachable!("Coding error: unexpected RPCSend variant {rpc_send:?}.") |
Collaborator
There was a problem hiding this comment.
Is it necessary to have this unreachable here? What about a debug assert?
| } | ||
|
|
||
| // Wait until the tokens have been regenerated, then run `next_peer_request_ready`. | ||
| tokio::time::sleep(Duration::from_secs(3)).await; |
Collaborator
There was a problem hiding this comment.
Can you set a custom quota so we don't have to wait 3 seconds here?
jimmygchen
added
waiting-on-author
|
Hi @ackintosh, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time. |
ackintosh
added
ready-for-review
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed & Proposed Changes
The pending requests in
delay_requestsmove toready_requestsbefore being returned bypoll_ready. One request is returned perpoll_readycall, so some pending requests might remain inready_requests. We need to remove the pending requests fromready_requests, just likedelay_requests, when a peer disconnects.