feat: presign for validator account #6747
Conversation
|
|
There was a problem hiding this comment.
Thank you for the PR! I have tested it and the feature is working. I have left some comments.
The CI check on formatting failed, also it would be great if you can sign the CLA.
I think it will also be nice to have a note highlighting the feature in the documentation, maybe before this section: https://lighthouse-book.sigmaprime.io/voluntary-exit.html#initiating-a-voluntary-exit
Thanks!
| let string_output = serde_json::to_string_pretty(&signed_voluntary_exit) | ||
| .map_err(|e| format!("Unable to convert to JSON: {}", e))?; | ||
|
|
||
| println!("{}", string_output); |
There was a problem hiding this comment.
While working on #6612 , initially I also printed out the signature. But then I realise it probably isn't much useful in practice - if users want to pre-sign an exit, they probably want the signature saved to a file. So I modified in this commit in that PR:
5a4f928
We can hear from others about this and edit accordingly.
There was a problem hiding this comment.
I think this is fine for now. Users can still pipe stdout to a file
michaelsproul
added
waiting-on-author
|
Marking this |
|
Ah sorry for dropping the ball on this! Will address when I get home tonight |
|
done! |
chong-he
added
ready-for-review
michaelsproul
added
ready-for-merge
Issue Addressed
#6746
Proposed Changes
Add a --presign flag to emit the json output to stdout instead of publishing the exit
Additional Info
The validator-manager is also a surface area to support via the http client interface