Allow compilation without LevelDB #6964
Closed
+19
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
enhancement
|
I need to re-enable at least one DB backend for the tests |
|
Some required checks have failed. Could you please take a look @michaelsproul? 🙏 |
|
Hi @michaelsproul, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time. |
mergify
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
To enable pure Rust builds of Lighthouse without LevelDB/LMDB/MDBX, this PR turns off LevelDB as a default feature at the
storedependency level.Without this change, the
--no-default-featuresflag is not sufficient to compile Lighthouse without LevelDB, because it only disables the default features of the top-level crate (./lighthouse/). With this change, you can pass--no-default-featuresand get a binary that only has Redb available as an argument to--beacon-node-backend.