Drop verify single RpcBlock fns #7008
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we merge this before: ? |
Independent, I can fix conflicts later. |
dapplion
force-pushed
the
drop-single-rpc-block-verify
branch
from
5d44eb0 to
d1273da
Compare
dapplion
added
ready-for-review
|
This pull request has merge conflicts. Could you please resolve them @dapplion? 🙏 |
mergify
bot
added
waiting-on-author
|
Some required checks have failed. Could you please take a look @dapplion? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Noted that we never have to verify individual RpcBlocks for sync. Lookup sync sends the block alone always, and range sync sends chain segments.
Proposed Changes
IntoExecutionPendingBlockimpl for RpcBlock. Now lookup sync blocks use the SignedBeaconBlockIntoExecutionPendingBlockimpl which is the same