Skip to content

fix: fix inconsistent flag naming: validator-dir vs validators-dir #7065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

hexcow
Copy link

@hexcow hexcow commented Mar 3, 2025

Proposed Changes

I noticed an inconsistency in the flag naming where validator-dir and validators-dir were used interchangeably. To avoid confusion, I standardized the flag to validator-dir throughout the code. This change ensures consistency and prevents potential issues when using the flags.

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2025

CLA assistant check
All committers have signed the CLA.

@michaelsproul michaelsproul added the backwards-incompat Backwards-incompatible API change label Mar 3, 2025
@michaelsproul
Copy link
Member

Your PR only updates the tests, you'll need to update the implementation as well.

PRs also need to be targeted at unstable please 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompat Backwards-incompatible API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants