-
Notifications
You must be signed in to change notification settings - Fork 870
Feat: add new --advertise-false-custody-group-count
cli flag for PeerDAS testing
#7120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Changes from 2 commits
83a73f5
d78867d
a111b56
d5c803d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -199,8 +199,12 @@ impl<E: EthSpec> Network<E> { | |||||||||||||||||||
|
||||||||||||||||||||
// Construct the metadata | ||||||||||||||||||||
let custody_group_count = ctx.chain_spec.is_peer_das_scheduled().then(|| { | ||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this affect both the ENR value and the value returned in the Status ReqResp message? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ENR is built with the metadata (false There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the user restarts the node with a different value of the false_count flag, will we bump the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I rechecked I don't think it bumps the lighthouse/beacon_node/lighthouse_network/src/discovery/enr.rs Lines 256 to 264 in bf955c7
|
||||||||||||||||||||
ctx.chain_spec | ||||||||||||||||||||
.custody_group_count(config.subscribe_all_data_column_subnets) | ||||||||||||||||||||
// Use the false custody group count if specified, otherwise use the normal one | ||||||||||||||||||||
if let Some(false_count) = config.advertise_false_custody_group_count { | ||||||||||||||||||||
false_count | ||||||||||||||||||||
} else { | ||||||||||||||||||||
ctx.chain_spec.custody_group_count(config.subscribe_all_data_column_subnets) | ||||||||||||||||||||
} | ||||||||||||||||||||
}); | ||||||||||||||||||||
let meta_data = utils::load_or_build_metadata(&config.network_dir, custody_group_count); | ||||||||||||||||||||
let seq_number = *meta_data.seq_number(); | ||||||||||||||||||||
|
Uh oh!
There was an error while loading. Please reload this page.