Implement basic validator custody #7262
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
added
work-in-progress
|
This pull request has merge conflicts. Could you please resolve them @dapplion? 🙏 |
beacon_node/network/src/service.rs
Outdated
| // We need backfill sync to fetch batches with `CGC_f = cgc_at_finalized_slot`. Then | ||
| // `custody_group_count(oldest_block_slot) should now return `CGC_f`. So we have to | ||
| // delete the CGC updates with `update.slot < finalized_slot` | ||
| todo!(); |
There was a problem hiding this comment.
To prevent concurrent updates of oldest_block_slot, we can get import_historical_block_batch to handle the mutation for us.
We can add an argument to that function, something like restart: bool, and set the oldest_block_{slot,root} to the last block in the batch passed in (allowing the oldest_block_slot to go up).
TODO: what if state reconstruction is running as well?
- Need to consider how state reconstruction depends on and modifies
oldest_block_slot. Should maybe makeas_archive_anchor()preserve the oldest block slot
Alternatively, make sure we only restart backfill if oldest_block_slot > 0 (might affect some testnets with FULU_FORK_EPOCH=0, but not mainnet). Actually we need to consider max(oldest_block_slot, fulu_fork_slot, clock_slot - da_window)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Also does a consistency check on the DB to make sure the stored columns are compatible
Not tested yet
Proposed Changes
TODO