Fix for #7212 Call engine_getBlobs as soon as receiving a valid data_column_sidecar from gossip #7329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-blobs-for-col-sidecar
|
Lock while fetching from EL yet enabled |
SunnysidedJ
changed the title
eserilev
added
das
pawanjay176
reviewed
Apr 21, 2025
There was a problem hiding this comment.
This looks good functionally.
However, I think there is scope to reduce duplication between the fetch_blobs_from_block v/s fetch_blobs_from_columns functions by simply changing the arguments to the block version and reusing them in the data_column functions.
Repeating the logic opens up to more bugs during further refactors
|
@SunnysidedJ I added a commit based on your branch to illustrate my suggestion 6fe3c5b Let me know if you disagree with the approach. Feel free to cherry-pick the commit to this PR |
jimmygchen
added
the
waiting-on-author
|
Some required checks have failed. Could you please take a look @SunnysidedJ? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#7212 Call engine_getBlobs as soon as receiving a valid data_column_sidecar from gossip
Proposed Changes
Copied how blobs are fetched when a block is gossiped. Test in progress, and code will be refactored to merge common code between fetching logics from block and column gossips
Additional Info
Please find the comments below