-
Notifications
You must be signed in to change notification settings - Fork 961
Implement weak subjectivity safety checks #7347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Changes from 11 commits
448f36d
48ee262
6ac8d99
c2b9f9f
1727167
e6fdd4d
1086b50
c995e6a
54228e0
b5adc67
8cb1a78
c09954a
83f6ac4
3d919f0
c524e98
5db3205
a2886a4
bc60964
5bb7d46
d808c07
73e6eb6
5243aaf
ccfbb8a
490ce0c
2ba18d3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1404,6 +1404,17 @@ pub fn cli_app() -> Command { | |
| .help_heading(FLAG_HEADER) | ||
| .display_order(0) | ||
| ) | ||
| .arg( | ||
| Arg::new("ignore-ws-check") | ||
| .long("ignore-ws-check") | ||
| .help("The Weak Subjectivity Period is the the maximum time a node can be offline and still \ | ||
| safely sync back to the canonical chain without the risk of falling victim to long-range attacks. \ | ||
| This flag disables the Weak Subjectivity check at startup, allowing users to run a node whose current head snapshot \ | ||
| is outside the Weak Subjectivity Period. It is unsafe to disable the Weak Subjectivity check at startup.") | ||
|
||
| .action(ArgAction::SetTrue) | ||
| .help_heading(FLAG_HEADER) | ||
| .display_order(0) | ||
| ) | ||
| .arg( | ||
| Arg::new("builder-fallback-skips") | ||
| .long("builder-fallback-skips") | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice message but I would order as:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated messaging order