Fix missing commas in logs

[ackintosh]

Issue Addressed

In beacon.log, commas are missing in case where multiple spans are present, for example:

Apr 05 07:03:07.646 DEBUG Sync's view on execution engine state updated  past_state: Online, new_state: Offline, service: "sync"service: "network_context"

A comma should be present between service: "sync" and service: "network_context" as shown in the example.

Proposed Changes

This PR:

• makes build_log_text() testable and adds unit tests for it
• fixes the missing commas issue

[macladson]

This has some of the same ideas as #7239, I'm wondering if you've had a chance to look at that PR? It would be good if we could make them compatible with each other.

[macladson]

I've written up a version of this PR on top of #7239
There's a few changes (commas are handled slightly differently and the span order for multiple spans is reversed).
I wanted to make sure you still get the credit for this fix so let me know what you think.

[mergify]

Hi @ackintosh, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time.