Allow for sync state where batch is unknown #7391
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
reviewed
May 5, 2025
| } else { | ||
| return Err(RemoveChain::WrongChainState(format!( | ||
| "Batch not found for current processing target {}", | ||
| self.processing_target |
There was a problem hiding this comment.
this will be a rare event, should we add a debug log? If we ever wonder why the SyncingChain is not processing anything
There was a problem hiding this comment.
I don't think it will ever stop processing, something will progress it, but agree a log would be handy
|
This pull request has merge conflicts. Could you please resolve them @AgeManning? 🙏 |
|
Some required checks have failed. Could you please take a look @AgeManning? 🙏 |
mergify
bot
added
the
waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7360 shows a bug where we attempt to process a batch that is not existent.
It can be non-existent for two reasons:
Under these conditions, the chain will be removed because there process_id pointer doesn't point to a batch.
This PR permits this state, by simply removing the error catch.