Remove reprocess channel #7437
Open
Remove reprocess channel #7437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Love this! |
|
Since reprocess and regular work events will all come through a single channel, we may need to raise the default work queue size like we're doing here: #7415 |
…v/lighthouse into remove-reprocess-channel
|
This pull request has merge conflicts. Could you please resolve them @eserilev? 🙏 |
mergify
bot
added
waiting-on-author
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
|
All required checks have passed and there are no merge conflicts. This pull request may now be ready for another review. |
mergify
bot
added
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Partially #6291
Proposed Changes
This PR removes the reprocess event channel from being externally exposed. All work events are now sent through the single
BeaconProcessorSendchannel. I've introduced a newWork::Reprocessenum variant which we then use to schedule jobs for reprocess. I've also created a new scheduler module which will eventually house the different scheduler impls.This is all needed as an initial step to generalize the beacon processor
A "full" implementation for the generalized beacon processor can be found here
#6448
I'm going to try to break up the full implementation into smaller PR's so it can actually be reviewed