Skip to content

Remove reprocess channel #7437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: unstable
Choose a base branch
from

Conversation

eserilev
Copy link
Collaborator

@eserilev eserilev commented May 11, 2025

Issue Addressed

Partially #6291

Proposed Changes

This PR removes the reprocess event channel from being externally exposed. All work events are now sent through the single BeaconProcessorSend channel. I've introduced a new Work::Reprocess enum variant which we then use to schedule jobs for reprocess. I've also created a new scheduler module which will eventually house the different scheduler impls.

This is all needed as an initial step to generalize the beacon processor

A "full" implementation for the generalized beacon processor can be found here
#6448

I'm going to try to break up the full implementation into smaller PR's so it can actually be reviewed

@eserilev eserilev requested a review from jxs as a code owner May 11, 2025 06:30
@michaelsproul
Copy link
Member

Nice! Love this!

@eserilev
Copy link
Collaborator Author

eserilev commented May 12, 2025

Since reprocess and regular work events will all come through a single channel, we may need to raise the default work queue size like we're doing here: #7415

@eserilev eserilev added the ready-for-review The code is ready for review label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants