Skip to content

Fix blob download from checkpointz servers #7495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented May 20, 2025

Issue Addressed

Closes:

Proposed Changes

Use ForkName::latest_stable, i.e. Electra when decoding blobs from a server that does not provide version. This is only a temporary workaround that should be reverted once checkpointz is fixed. Having a default fork is potentially incorrect, and glossing over bugs in servers in general is not ideal.

However, even in the case where we update ForkName::latest_stable to Fulu, this should continue to work, as the blob limit is likely to increase and the RuntimeVariableList will just have a slightly higher limit than necessary (which is OK so long as the server isn't buggy enough to violate the correct lower bound: e.g. if the block is an Electra one and the server sends 10 blobs, which exceeds the Electra max (9) but not the Fulu max).

Additional Info

I've opened an issue to revert this PR before we proceed with Fulu on mainnet, but after v7.1.0:

Copy link

mergify bot commented May 20, 2025

Some required checks have failed. Could you please take a look @michaelsproul? 🙏

@mergify mergify bot added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label May 20, 2025
@michaelsproul michaelsproul added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The code is ready for review v7.1.0 Post-Electra release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant