Allow for constructing light client data across fork boundaries #7502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
added
bug
eserilev
commented
May 20, 2025
Comment on lines
+498
to
+514
| builder.register_anonymous_variable_length_item()?; | ||
| builder.register_type::<SyncCommittee<E>>()?; | ||
| if fork_name.electra_enabled() { | ||
| builder.register_type::<NextSyncCommitteeBranchElectra>()?; | ||
| } else { | ||
| builder.register_type::<NextSyncCommitteeBranch>()?; | ||
| } | ||
| // FINALIZED HEADER | ||
| builder.register_anonymous_variable_length_item()?; | ||
| if fork_name.electra_enabled() { | ||
| builder.register_type::<FinalityBranchElectra>()?; | ||
| } else { | ||
| builder.register_type::<FinalityBranch>()?; | ||
| } | ||
| builder.register_type::<SyncAggregate<E>>()?; | ||
| builder.register_type::<Slot>()?; | ||
| let mut decoder = builder.build()?; |
There was a problem hiding this comment.
There is an OffsetOutOfBounds failure on line 506 when I try to register the finalized header as an anonymous variable length item. I'm not sure why
There was a problem hiding this comment.
cargo test --release -p ef_tests --features "ef_tests" -- light_client_update
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
bot
added
the
waiting-on-author
eserilev
removed
the
waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#7002
Proposed Changes
LightClientUpdatedata can contain an attested header and finalized header that originate from different forks. This usually happens during hardforks while an epoch in the new fork hasn't been finalized yet. This PR allows for us to constructLightClientUpdates in this scenario.