-
Notifications
You must be signed in to change notification settings - Fork 876
Downscore and retry custody failures #7510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dapplion
wants to merge
15
commits into
peerdas-devnet-7
Choose a base branch
from
peerdas-rangesync
base: peerdas-devnet-7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4fb2ae6
Implement reliable range sync for PeerDAS
dapplion 801659d
Resolve some TODOs
dapplion b383f7a
More comments
dapplion 7d0fb93
Reduce conversions
dapplion c8a0c9e
Remove CustodyByRoot and CustodyByRange types
dapplion 01329ab
Improve RangeBlockComponent type
dapplion 34b37b9
Remove unused module
dapplion 8f74adc
Use DataColumnSidecarList
dapplion 86ad87e
Lint tests
dapplion 52722b7
Resolve TODO(das)
dapplion fc3922f
Resolve more TODOs
dapplion 0ef95dd
Remove stale TODO
dapplion 144b83e
Remove BatchStateSummary
dapplion 02d9737
Address review comments
dapplion c6b39e9
Merge remote-tracking branch 'sigp/peerdas-devnet-7' into peerdas-ran…
dapplion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it matters currently - but thought might be worth mentioning - we use
config.subscribe_all_data_column_subnets
for determine the gossip topics, and it doesn't seem like we use it for determiningis_supernode
elsewhere, but something to keep in mind - if we want consistency maybe we can deriveis_supernode
from network config, but that may not be relevant from once we move to validator custody.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, we should revisit after impl validator custody. Since this function is for unit tests without gossip, it doesn't matter