Removed code for GET validator/blinded_blocks and also adjusted/removed tests
#7515
+223
−628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PoulavBhowmick03
force-pushed
the
remove/blinded_blocks
branch
from
0d463bd to
7cfbced
Compare
PoulavBhowmick03
changed the title
validator/blinded_blocks and also adjusted/removed tests
…ed tests for that endpoint
PoulavBhowmick03
force-pushed
the
remove/blinded_blocks
branch
from
7cfbced to
b0b57b5
Compare
|
@michaelsproul @eserilev PTAL at this |
michaelsproul
added
ready-for-review
michaelsproul
requested changes
May 25, 2025
| ProduceBlockV3Response::Blinded(payload) => { | ||
| payload.body().execution_payload().unwrap().into() | ||
| } | ||
| ProduceBlockV3Response::Full(_) => panic!("Expecting a full payload"), |
There was a problem hiding this comment.
Suggested change
| ProduceBlockV3Response::Full(_) => panic!("Expecting a full payload"), | |
| ProduceBlockV3Response::Full(_) => panic!("Expecting a blinded payload"), |
| ProduceBlockV3Response::Blinded(payload) => { | ||
| payload.body().execution_payload().unwrap().into() | ||
| } | ||
| ProduceBlockV3Response::Full(_) => panic!("Expecting a full payload"), |
There was a problem hiding this comment.
Suggested change
| ProduceBlockV3Response::Full(_) => panic!("Expecting a full payload"), | |
| ProduceBlockV3Response::Full(_) => panic!("Expecting a blinded payload"), |
| self | ||
| } | ||
|
|
||
| pub async fn test_blinded_block_production_verify_randao_invalid(self) -> Self { |
There was a problem hiding this comment.
I need to review this more tomorrow, but maybe we could keep these tests and use blocks_v3 with a non-None value to force builder usage
michaelsproul
added
waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fixes #7456
Proposed Changes
Remove client/server code for deprecated GET
validator/blinded_blocksendpoint and subsequently, removed the tests which were just testing the blinded endpoint, and modified other endpoints to use the new GET/eth/v3/validator/blocksendpointAdditional Info
None