Skip to content

Conversation

@macladson
Copy link
Member

Issue Addressed

I noticed that the logging crate was often being spuriously recompiled due to the workspace_crates macro running even when no changes needed to be made.

Proposed Changes

This removes the proc macro and instead uses a build script to construct the list of workspace members and save them to a file in logging's OUT_DIR. This build script should only be rerun when actually necessary which should reduce spurious recompiles.

Additional Info

The build script will be rerun when:

  1. This build.rs file is changed.
  2. The workspace Cargo.toml changes.
  3. Build dependencies change.

@macladson macladson added the work-in-progress PR is a work-in-progress label Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work-in-progress PR is a work-in-progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant