Remove workspace_members proc macro
#8644
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
I noticed that the
loggingcrate was often being spuriously recompiled due to theworkspace_cratesmacro running even when no changes needed to be made.Proposed Changes
This removes the proc macro and instead uses a build script to construct the list of workspace members and save them to a file in
logging'sOUT_DIR. This build script should only be rerun when actually necessary which should reduce spurious recompiles.Additional Info
The build script will be rerun when: