Skip to content

Conversation

@macladson
Copy link
Member

Issue Addressed

#8652

Proposed Changes

This moves the ExecutionBlockHash from the execution module to the core module. This allows core to not depend on the execution module, and the ExecutionBlockHash is a pretty core part of our types so I think it makes sense.

Additional Information

Ideally we would pull this type from alloy, but I think with our specific requirements, particularly around tree_hash and ssz, that might not be viable.

@macladson macladson added ready-for-review The code is ready for review code-quality labels Jan 15, 2026
@macladson macladson changed the title Remove execution dependency in types core module Remove execution dependency from core module in consensus/types Jan 15, 2026
@pawanjay176 pawanjay176 added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 16, 2026
@mergify mergify bot added the queued label Jan 16, 2026
@mergify
Copy link

mergify bot commented Jan 16, 2026

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at 0c65e10

This pull request spent 1 hour 1 minute 31 seconds in the queue, including 23 minutes 1 second running CI.
The checks were run on draft #8669.

Reason

The merge conditions cannot be satisfied due to failing checks

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify bot added a commit that referenced this pull request Jan 16, 2026
@mergify mergify bot added dequeued and removed queued labels Jan 16, 2026
@mergify mergify bot removed the dequeued label Jan 16, 2026
@macladson
Copy link
Member Author

@Mergifyio requeue

@mergify
Copy link

mergify bot commented Jan 16, 2026

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify
Copy link

mergify bot commented Jan 16, 2026

Merge Queue Status

✅ The pull request has been merged at 277dfaf

This pull request spent 37 minutes 47 seconds in the queue, including 36 minutes 3 seconds running CI.
The checks were run on draft #8671.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

@mergify mergify bot added the queued label Jan 16, 2026
mergify bot added a commit that referenced this pull request Jan 16, 2026
@mergify mergify bot merged commit d099ad5 into sigp:unstable Jan 16, 2026
36 checks passed
@mergify mergify bot removed the queued label Jan 16, 2026
@macladson macladson deleted the remove-execution-dep-from-core-types branch January 16, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants