-
Notifications
You must be signed in to change notification settings - Fork 961
Remove execution dependency from core module in consensus/types
#8666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove execution dependency from core module in consensus/types
#8666
Conversation
execution dependency in types core moduleexecution dependency from core module in consensus/types
Merge Queue Status🚫 The pull request has left the queue (rule: This pull request spent 1 hour 1 minute 31 seconds in the queue, including 23 minutes 1 second running CI. ReasonThe merge conditions cannot be satisfied due to failing checks HintYou may have to fix your CI before adding the pull request to the queue again. |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Merge Queue Status✅ The pull request has been merged at 277dfaf This pull request spent 37 minutes 47 seconds in the queue, including 36 minutes 3 seconds running CI. Required conditions to merge
|
Issue Addressed
#8652
Proposed Changes
This moves the
ExecutionBlockHashfrom theexecutionmodule to thecoremodule. This allowscoreto not depend on theexecutionmodule, and theExecutionBlockHashis a pretty core part of our types so I think it makes sense.Additional Information
Ideally we would pull this type from
alloy, but I think with our specific requirements, particularly aroundtree_hashandssz, that might not be viable.