Remove remaining facade module re-exports from consensus/types
#8672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macladson
added
ready-for-review
|
Some required checks have failed. Could you please take a look @macladson? 🙏 |
mergify
bot
added
waiting-on-author
mergify
bot
added
ready-for-review
pawanjay176
approved these changes
Jan 16, 2026
Member
pawanjay176
left a comment
pawanjay176
left a comment
There was a problem hiding this comment.
Again only mechanical changes that followed from removing the re-exports from the types crate.
LGTM
pawanjay176
added
ready-for-merge
Merge Queue Status✅ The pull request has been merged at fb010d3 This pull request spent 40 minutes 20 seconds in the queue, including 37 minutes 41 seconds running CI. Required conditions to merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Removes the remaining facade re-exports from
consensus/types.I have left
graffitias I think it has some utility so am leaning towards keeping it in the final API design.Additional Info
Previous PRs:
consensus/typesre-exports #8643consensus/typesre-export cleanup #8665