Remove syn version 1
#8678
Open
Remove syn version 1
#8678
+155
−236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#8547
Proposed Changes
This updates a few of our crates to remove the older
syn 1crate.This updates:
criterionitertoolsAnd also certain
sigpcrates:xdelta3superstructethereum_ssztree_hashmetastructcontext_deserializecompare_fieldsThis PR is blocked by (and currently implements) #8659 as it is required to properly remove
syn.Additional Info
syn 1still exists in the lockfile as a dependency ofark-ffwhich is an optional dep of alloy (which we don't use), but we no longer compile it.