merge queue: embarking unstable (21cabba) and #8647 together #8693
+139
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add AllowedRootSpanSampler to filter out traces that don't originate from known instrumented code paths. This reduces noise from library code and uninstrumented paths when exporting to OTLP backends. Uses the idiomatic OpenTelemetry ParentBased sampler pattern: - Root spans are sampled only if their name is in LH_BN_ROOT_SPAN_NAMES - Child spans automatically inherit their parent's sampling decision - Efficient head-based sampling with no per-span tracking overhead This enables effective trace sampling in production - without filtering, the majority of traces would be noise, making low sample rates ineffective at capturing meaningful instrumented code paths.
Replace the allowlist-based AllowedRootSpanSampler with a generic `PrefixBasedSampler` that filters spans by prefix. Root spans now use the `lh_` prefix to identify Lighthouse instrumented entry points.
Changes:
- Rename `lighthouse_tracing` to `tracing_samplers` and move to `common/`
- Replace `AllowedRootSpanSampler` with `PrefixBasedSampler`
- Remove all `SPAN_*` constants, use inline strings at call sites
- Remove `LH_BN_ROOT_SPAN_NAMES` allowlist
This eliminates the need to maintain an allowlist of span names. New instrumented spans just need the `lh_` prefix to be exported. The sampler is now generic and can be reused by validator_client.
|
|
1 similar comment
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch unstable (21cabba) and #8647 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #8647.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:check-success=local-testnet-successcheck-success=test-suite-successRequired conditions to stay in the queue:
#approved-reviews-by >= 1check-success=license/clacheck-success=target-branch-checklabel!=do-not-merge